On Fri, May 12, 2006 at 01:52:15PM -0700, Greg KH wrote: > On Fri, May 12, 2006 at 09:38:50PM +0100, Russell King wrote: > > On Fri, May 12, 2006 at 12:09:50PM -0700, Linus Torvalds wrote: > > > On Fri, 12 May 2006, James Bottomley wrote: > > > > I suggest simply reversing this patch at the moment. If Russell and > > > > Jens can tell me what they're trying to do I'll see if there's another > > > > way to do it. > > > > > > Reverted, with a big changelog entry to explain why. > > > > Great, I'm fucked by the SCSI folk again. > > > > Can we revert the patch which broke the MMC/SD layer - the one which > > added the mount/unmount hotplug events as well then. > > Why would the mount/unmount hotplug event change break MMC/SD? Do you > have a reference to the patch in question? Please read the commit message in the change in question. The block layer holds on to a reference to a struct device which isn't refcounted (until I added it with my patch.) Hence struct gendisk structures have a completely independent lifetime and are only destroyed when all references to them are removed. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
