Andries Brouwer <Andries.Brouwer@xxxxxx> wrote:
>
> On Tue, May 09, 2006 at 12:41:38PM -0700, Andrew Morton wrote:
>
> > > + if (from+size-1 > get_capacity(disk)) {
> > > + printk(" %s: p%d exceeds device capacity, ignoring.\n",
> > > + disk->disk_name, p);
> > > + continue;
> > > + }
> > > add_partition(disk, p, from, size);
>
> > Shouldn't that be
> >
> > if (from+size > get_capacity(disk)) {
> >
> > ?
>
> Ha, you are awake.
Opinions differ.
> Yes, it should.
> And no "ignoring". And no "continue". E.g.:
>
> printk(" %s: warning: p%d exceeds device capacity.\n", ...);
>
So you're saying that after detecting this inconsistency we should proceed
to use the partition anyway?
For what reason?
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
