On Wed, May 10, 2006 at 01:59:36AM +0400, Alexey Dobriyan wrote:
> That plethora of HPT_IOCTL_* defines, where are you using them? What
> arguments are passed in and out?
Argh, sorry for confusion, I've checked several first in the list and wrongly
concluded nothing is used. Anyway, please, remove unused HPT_IOCTL_ defines.
> #ifdef MODULE_LICENSE
> MODULE_LICENSE("GPL");
> #endif
#ifdef is totally unneeded.
Module init and exit functions should be marked with __init and __exit
resp.
Use DMA_??BIT_MASK in calls to pci_set_dma_mask(). See
include/linux/dma-mapping.h for readily available items.
hptiop_get_logical_devices can return -1 and you'll end up with
for (j = 0; j < -1; j++)
in hptiop_show_devicelist()
u64 things are printed as
"%llu", (unsigned long long)capacity
Is unsigned long long enough in this case?
I also suggest to use vsnprintf() in hptiop_copy_info() because you use
it with strings.
Funny, that you do
driveid->model[20] = 0;
when ->model is in fact 40 chars long.
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
