On 2006-05-01 at 19:45:19 +0200, Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote: > On Mon, 2006-05-01 at 10:15 -0700, akpm@xxxxxxxx wrote: > > diff -puN drivers/scsi/53c700.c~drivers-scsi-use-array_size-macro drivers/scsi/53c700.c > > --- devel/drivers/scsi/53c700.c~drivers-scsi-use-array_size-macro 2006-05-01 10:15:39.000000000 -0700 > > +++ devel-akpm/drivers/scsi/53c700.c 2006-05-01 10:15:39.000000000 -0700 > > @@ -316,7 +316,7 @@ NCR_700_detect(struct scsi_host_template > > BUG_ON(!dma_is_consistent(pScript) && L1_CACHE_BYTES < dma_get_cache_alignment()); > > hostdata->slots = (struct NCR_700_command_slot *)(memory + SLOTS_OFFSET); > > hostdata->dev = dev; > > - > > + > > pSlots = pScript + SLOTS_OFFSET; > > > > /* Fill in the missing routines from the host template */ > > noise? I usually remove trailing whitespaces which are around the section I'm patching (I highlight them in my vim). Is that a problem? > > @@ -332,19 +332,18 @@ NCR_700_detect(struct scsi_host_template > > tpnt->slave_destroy = NCR_700_slave_destroy; > > tpnt->change_queue_depth = NCR_700_change_queue_depth; > > tpnt->change_queue_type = NCR_700_change_queue_type; > > - > > + > > more noise? Same here > > @@ -385,17 +382,17 @@ NCR_700_detect(struct scsi_host_template > > host->hostdata[0] = (unsigned long)hostdata; > > /* kick the chip */ > > NCR_700_writeb(0xff, host, CTEST9_REG); > > - if(hostdata->chip710) > > + if (hostdata->chip710) > > while a nice cleanup.. does it fit in this patch? > > > (many more such things snipped) I probably should have mentioned the whitespace/coding style cleanups in the description of the patch. Or should I just leave out these kind of cleanups? - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
