On Monday 10 April 2006 11:43, Stefan Richter wrote: > Denis Vlasenko wrote: > ... > > +++ linux-2.6.16.aic7/drivers/scsi/aic7xxx/aic79xx_core.c Sun Apr 9 21:49:25 2006 > ... > > +#include "aic79xx_osm_o.c" > > +#include "aic79xx_inline.c" > ... > > +++ linux-2.6.16.aic7/drivers/scsi/aic7xxx/aic7xxx_core.c Sun Apr 9 21:49:25 2006 > ... > > +#include "aic7xxx_osm_o.c" > > +#include "aic7xxx_inline.c" > ... > > Instead of including c files with function definitions, you should add > function prototypes to header files (it seems you already did so) and > include only the header files. Include these header files in the c files > which call the functions as well as in the c files which define the > functions. I will do this if maintainer will inform me that he wants it done. Or maybe he wants it done in some other way, who knows? I am not lazy, I am just not good at reading other peoples' minds. > It is obviously necessary to modify the Makefile to have aic7?xx_osm_o.o > and aic7?xx_inline.o linked to an appropriate .ko file. I did compile test my changes. > Furthermore, aic7?xx_inline.c are not very fitting file names since they > do not contain inline functions. aic7?xx_osm_o.c are somewhat strange > names either. Can't you move the functions into existing c files? E.g. I can, but I won't without maintainer's consent. > into those which contain most of the calls to the now de-inlined > functions. From the point of view of cross-OS driver maintenance (but > not necessarily from the point of view of Linux driver maintenance), it > may be useful to distinguish between functions used across OSs and those > used only in Linux when deciding where to move the functions. -- vda - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
