On Monday 10 April 2006 10:19, Rolf Eike Beer wrote: > [Full quote and readded CC adresses. My fault, pressed wrong button] > > Denis Vlasenko wrote: > > On Monday 10 April 2006 10:03, Rolf Eike Beer wrote: > > > Am Montag, 10. April 2006 07:49 schrieben Sie: > > > > On Monday 10 April 2006 08:44, Denis Vlasenko wrote: > > > > > I also spotted two bugs in the process, patches > > > > > for those will follow. > > > > > > > > ahd_delay(usec) is buggy. Just think how would it work > > > > with usec == 1024*100 + 1... > > > > > > This is unneeded. The biggest argument this function is ever called with > > > is 1000. > > > > I know. > > > > > I would suggest to delete this function completely. If one ever has to > > > wait for a longer period mdelay() is the right function to call. > > > > I am leaving it up to maintainer to decide. After all, the driver > > is for multiple OSes, other OS may lack mdelay(). > > The comment says about multiple milliseconds sleeps which just don't happen. # grep -r ah._delay.[A-Z] . ./aic7xxx_core.c: ahc_delay(AHC_BUSRESET_DELAY); ./aic79xx_core.c: ahd_delay(AHD_BUSRESET_DELAY); ./aic79xx_core.c: ahd_delay(AHD_BUSRESET_DELAY); I am not sure that this constant won't be redefined to something large. If maintainer knows better, he can take care of it. I just fixed an obvious latent bug. -- vda - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
