On Sat, 2006-04-01 at 21:58 +0200, Stefan Richter wrote: > Arjan van de Ven wrote: > > On Sat, 2006-04-01 at 19:21 +0200, Christoph Hellwig wrote: > >>Overriding the whole EH code is a per-transport, not per-host thing. > >>Move ->eh_strategy_handler to the transport class, same as > >>->eh_timed_out. > > > > I like it, nice cleanup and it's fundamentally the right place to do it > > BTW, why are there Scsi_Hosts in (s)ata drivers anyway instead of being > hidden by libata? (Think of libata---or a transport class---as a layer.) this is basically how linux does OOP :) the lowest level driver instantiates the object, but sets it with helper/library functions ("methods" in OOP speak) from the higher layers. It gives a really clean model in the light of a world where "hardware does weird shit" which can't be "nicely" mapped in traditional OOP paradigms, but works quite well in this linux model. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html