Re: [CMT 04/16] qla4xxx: driver review ql4_def.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Several of the #defines are not used anywhere in the driver.  Best to
add when needed.

Some fields related to network addressing appear to only support ipv4.
Will ipv6 ever be supported with this hardware?

The {RD,WRT} macros seem to be just wrappers for the appropriate linux
calls.  These should be open coded.

Several lines exceed the 80 byte limit, but that may not be that big
of a deal in header file.

Finally in scsi_qla_host, volatile decls are somewhat problematic, and
deprecated.  David Howells Linux Memory Barrier did address them at
one point, but I don't see them mentioned in try #7.

++doug
--
diff --git a/drivers/scsi/qla4xxx/ql4_def.h b/drivers/scsi/qla4xxx/ql4_def.h
new file mode 100644
index 0000000..079c9d7
--- /dev/null
+++ b/drivers/scsi/qla4xxx/ql4_def.h
@@ -0,0 +1,565 @@
+/*
+ * QLogic iSCSI HBA Driver
+ * Copyright (c)  2003-2006 QLogic Corporation
+ *
+ * See LICENSE.qla4xxx for copyright and licensing details.
+ */
+
+#ifndef __QL4_DEF_H
+#define __QL4_DEF_H
+
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/types.h>
+#include <linux/module.h>
+#include <linux/list.h>
+#include <linux/pci.h>
+#include <linux/dma-mapping.h>
+#include <linux/sched.h>
+#include <linux/slab.h>
+#include <linux/dmapool.h>
+#include <linux/mempool.h>
+#include <linux/spinlock.h>
+#include <linux/kthread.h>
+#include <linux/delay.h>
+#include <linux/interrupt.h>
+#include <linux/mutex.h>
+
+#include <scsi/scsi.h>
+#include <scsi/scsi_host.h>
+#include <scsi/scsi_device.h>
+#include <scsi/scsi_cmnd.h>
+#include <scsi/scsi_transport.h>
+#include <scsi/scsi_transport_iscsi.h>
+
+/* XXX(dg): move to pci_ids.h */
+#ifndef PCI_DEVICE_ID_QLOGIC_ISP4010
+#define PCI_DEVICE_ID_QLOGIC_ISP4010	0x4010
+#endif
+
+#ifndef PCI_DEVICE_ID_QLOGIC_ISP4022
+#define PCI_DEVICE_ID_QLOGIC_ISP4022	0x4022
+#endif				/*  */
+
+#define IS_QLA4010(ha)	((ha)->pdev->device == PCI_DEVICE_ID_QLOGIC_ISP4010)
+#define IS_QLA4022(ha)	((ha)->pdev->device == PCI_DEVICE_ID_QLOGIC_ISP4022)
+
+#define QLA_SUCCESS			0
+#define QLA_ERROR			1
+
+/*
+ * Data bit definitions
+ */

The following could be open coded.  Or some other meaning full value.

+#define BIT_0	0x1
+#define BIT_1	0x2
+#define BIT_2	0x4
+#define BIT_3	0x8
+#define BIT_4	0x10
+#define BIT_5	0x20
+#define BIT_6	0x40
+#define BIT_7	0x80
+#define BIT_8	0x100
+#define BIT_9	0x200
+#define BIT_10	0x400
+#define BIT_11	0x800
+#define BIT_12	0x1000
+#define BIT_13	0x2000
+#define BIT_14	0x4000
+#define BIT_15	0x8000
+#define BIT_16	0x10000
+#define BIT_17	0x20000
+#define BIT_18	0x40000
+#define BIT_19	0x80000
+#define BIT_20	0x100000
+#define BIT_21	0x200000
+#define BIT_22	0x400000
+#define BIT_23	0x800000
+#define BIT_24	0x1000000
+#define BIT_25	0x2000000
+#define BIT_26	0x4000000
+#define BIT_27	0x8000000
+#define BIT_28	0x10000000
+#define BIT_29	0x20000000
+#define BIT_30	0x40000000
+#define BIT_31	0x80000000
+
+#define IPAddrIsZero( _X1_ )   ((_X1_)[0] == 0 && \
+                                (_X1_)[1] == 0 && \
+                                (_X1_)[2] == 0 && \
+                                (_X1_)[3] == 0)

-ENOTUSED

+#define IPAddrIsEqual(_X1_, _X2_) ((_X1_)[0] == (_X2_)[0] && \
+                                   (_X1_)[1] == (_X2_)[1] && \
+                                   (_X1_)[2] == (_X2_)[2] && \
+                                   (_X1_)[3] == (_X2_)[3])

-ENOTUSED

+#define IPAddr2Uint32(_X1_,_X2_) { \
+                                  *_X2_ = 0; \
+				  *_X2_ |= _X1_[3] << 24; \
+				  *_X2_ |= _X1_[2] << 16; \
+				  *_X2_ |= _X1_[1] << 8;  \
+				  *_X2_ |= _X1_[0];}

-ENOTUSED

+/*
+ * Host adapter default definitions
+ ***********************************/
+#define MAX_HBAS			16
+#define MAX_BUSES       		1

-ENOTUSED

+#define MAX_TARGETS     		MAX_PRST_DEV_DB_ENTRIES + MAX_DEV_DB_ENTRIES
+#define MAX_LUNS        		0xffff
+#define MAX_AEN_ENTRIES 		256	/* should be > EXT_DEF_MAX_AEN_QUEUE */
+#define MAX_DDB_ENTRIES 		MAX_PRST_DEV_DB_ENTRIES + MAX_DEV_DB_ENTRIES
+#define MAX_PDU_ENTRIES                 32
+#define INVALID_ENTRY			0xFFFF

different case than other hex values in the series.

+#define MAX_CMDS_TO_RISC		1024
+#define MAX_SRBS			MAX_CMDS_TO_RISC
+#define MBOX_AEN_REG_COUNT		5
+#define MAX_INIT_RETRIES		5
+#define IOCB_HIWAT_CUSHION		16
+
+/*
+ * Buffer sizes
+ */
+#define REQUEST_QUEUE_DEPTH       	MAX_CMDS_TO_RISC
+#define RESPONSE_QUEUE_DEPTH      	64
+#define QUEUE_SIZE			64
+#define DMA_BUFFER_SIZE 		512

-ENOTUSED

+
+/*
+ * Misc
+ */
+#define MAC_ADDR_LEN			6	/* in bytes */
+#define IP_ADDR_LEN			4	/* in bytes */

will this driver ever handle ipv6?

+#define DRIVER_NAME			"qla4xxx"
+
+#define MAX_LINKED_CMDS_PER_LUN		3

-ENOTUSED

+#define MAX_REQS_SERVICED_PER_INTR	16
+
+#define	ISCSI_IPADDR_SIZE		4	/* IP address size */

same ipv6 question


+#define	ISCSI_ALIAS_SIZE		32	/* ISCSI Alais name size */

-ENOTUSED

+#define	ISCSI_NAME_SIZE			255	/* ISCSI Name size  - usually a string */
+
+#define SYS_DELAY(x)		do {udelay(x);barrier();} while(0);

-ENOTUSED

+#define QLA4XXX_DELAY(sec)  	do {mdelay(sec * 1000);} while(0);

-ENOTUSED

+#define NVRAM_DELAY() 		do {udelay(500);} while(0);	/* 500 microsecond delay */

-ENOTUSED

+
+#define LSB(x)	((uint8_t)(x))

-ENOTUSED

+#define MSB(x)	((uint8_t)((uint16_t)(x) >> 8))

-ENOTUSED

+#define LSW(x)	((uint16_t)(x))

-ENOTUSED

+#define MSW(x)	((uint16_t)((uint32_t)(x) >> 16))

-ENOTUSED

+#define LSDW(x)	((uint32_t)((uint64_t)(x)))
+#define MSDW(x)	((uint32_t)((((uint64_t)(x)) >> 16) >> 16))
+
+/*
+ * I/O port access macros
+ *************************/
+#define RD_REG_BYTE(addr)		readb(addr)
+#define RD_REG_WORD(addr)		readw(addr)
+#define RD_REG_DWORD(addr)		readl(addr)
+#define RD_REG_WORD_RELAXED(addr)	readw_relaxed(addr)
+#define RD_REG_DWORD_RELAXED(addr)	readl_relaxed(addr)
+#define WRT_REG_BYTE(addr, data)	writeb(data, addr)
+#define WRT_REG_WORD(addr, data)	writew(data, addr)
+#define WRT_REG_DWORD(addr, data)	writel(data, addr)
+
+#define PCI_POSTING(a) (RD_REG_DWORD(a))

All the following {RD,WRT} could be open coded to use the normal call.

+
+#define CMD_SP(Cmnd)	    ((Cmnd)->SCp.ptr)
+
+#include "ql4_fw.h"
+#include "ql4_nvram.h"
+
+/*
+ * Retry & Timeout Values
+ */
+#define MBOX_TOV			60
+#define SOFT_RESET_TOV			30
+#define RESET_INTR_TOV			3
+#define SEMAPHORE_TOV			10

-ENOTUSED

+#define ADAPTER_INIT_TOV		120
+#define ADAPTER_RESET_TOV		180

-ENOTUSED

+#define EXTEND_CMD_TOV			60

-ENOTUSED

+#define WAIT_CMD_TOV			30
+#define EH_WAIT_CMD_TOV			120
+#define FIRMWARE_UP_TOV			60
+#define RESET_FIRMWARE_TOV        	30

-ENOTUSED

+#define LOGOUT_TOV			10
+#define IOCB_TOV_MARGIN			10

-ENOTUSED

+#define RELOGIN_TOV			18
+#define ISNS_DEREG_TOV			5

-ENOTUSED

+
+#define MAX_RESET_HA_RETRIES		2
+
+/*
+ * SCSI Request Block structure  (srb)  that is placed
+ * on cmd->SCp location of every I/O     [We have 22 bytes available]
+ */
+typedef struct _srb_t {
+	struct list_head list;	/* (8)   */
+	struct scsi_qla_host *ha;	/* HA the SP is queued on */
+	struct ddb_entry 	*ddb;
+	uint16_t flags;		/* (1) Status flags. */
+
+#define SRB_DMA_VALID		BIT_3	/* DMA Buffer mapped. */
+
+#define SRB_GOT_SENSE		BIT_4	/* sense data recieved. */
+#define SRB_IOCTL_CMD		BIT_5	/* generated from an IOCTL. */
+#define SRB_BUSY		BIT_7	/* in busy retry state. */
+
+#define SRB_FO_CANCEL		BIT_8	/* don't need to failover. */
+#define SRB_RETRY		BIT_9	/* needs retrying. */
+#define SRB_TAPE		BIT_10	/* FCP2 (Tape) command. */
+	uint8_t state;		/* (1) Status flags. */
+
+#define SRB_NO_QUEUE_STATE	 0	/* Request is in between states */
+#define SRB_FREE_STATE		 1
+#define SRB_ACTIVE_STATE	 3
+#define SRB_ACTIVE_TIMEOUT_STATE 4
+#define SRB_SUSPENDED_STATE  	 7	/* Request in suspended state */
+
+	struct scsi_cmnd *cmd;	/* (4) SCSI command block */
+	dma_addr_t dma_handle;	/* (4) for unmap of single transfers */
+	atomic_t ref_count;	/* reference count for this srb */
+	uint32_t fw_ddb_index;
+	uint8_t err_id;		/* error id */
+#define SRB_ERR_PORT       1	/* Request failed because "port down" */
+#define SRB_ERR_LOOP       2	/* Request failed because "loop down" */
+#define SRB_ERR_DEVICE     3	/* Request failed because "device error" */
+#define SRB_ERR_OTHER      4
+
+	uint16_t reserved;
+	uint16_t iocb_tov;
+	uint16_t iocb_cnt;	/* Number of used iocbs */
+	uint16_t cc_stat;
+	u_long r_start;		/* Time we recieve a cmd from OS */
+	u_long u_start;		/* Time when we handed the cmd to F/W */
+} srb_t;

Is this device data?  Are these values always big endian?  Consider
using the __{le,be} variants for clarity.

+
+/* Never set this to Zero */
+#define SUSPEND_SECONDS	6

-ENOTUSED

+#define SUSPEND_RETRIES	1

-ENOTUSED

+
+	/*
+	 * Device Database (DDB) structure
+	 */
+typedef struct ddb_entry {
+	struct list_head list;	/* ddb list */
+	struct scsi_qla_host *ha;
+	struct iscsi_cls_session	*session;
+	atomic_t state;		/* DDB State */
+
+	unsigned long flags;	/* DDB Flags */
+
+	unsigned long dev_scan_wait_to_start_relogin;
+	unsigned long dev_scan_wait_to_complete_relogin;
+
+	uint16_t os_target_id;	/* Target ID */
+	uint16_t fw_ddb_index;	/* DDB firmware index */
+	uint8_t reserved[2];
+	uint32_t fw_ddb_device_state;	/* F/W Device State  -- see ql4_fw.h */
+
+	uint32_t CmdSn;
+	uint16_t target_session_id;
+	uint16_t connection_id;
+	uint16_t exe_throttle;	/* Max mumber of cmds outstanding simultaneously */
+	uint16_t task_mgmt_timeout;	/* Min time for task mgmt cmds to complete */
+	uint16_t default_relogin_timeout;	/*  Max time to wait for relogin to complete */
+	uint16_t tcp_source_port_num;
+	uint32_t default_time2wait;	/* Default Min time between relogins (+aens) */
+
+	atomic_t port_down_timer;	/* Device connection timer */
+	atomic_t retry_relogin_timer;	/* Min Time between relogins (4000 only) */
+	atomic_t relogin_timer;	/* Max Time to wait for relogin to complete */
+	atomic_t relogin_retry_count;	/* Num of times relogin has been retried */
+
+	uint8_t ip_addr[ISCSI_IPADDR_SIZE];
+	uint8_t iscsi_name[ISCSI_NAME_SIZE];	/* 72 x48 */
+	uint8_t iscsi_alias[0x20];

this could use the ISCSI_ALIAS_SIZE.

+} ddb_entry_t;
+
+/*
+ * DDB states.
+ */
+#define DDB_STATE_DEAD		0	/* We can no longer talk to this device */
+#define DDB_STATE_ONLINE	1	/* Device ready to accept commands */
+#define DDB_STATE_MISSING	2	/* Device logged off, trying to re-login */
+#define DDB_STATE_TBL(){	  \
+		"DEAD"			, \
+		"ONLINE"		, \
+		"MISSING"		, \
+		NULL			  \
+	}

-ENOTUSED

+
+/*
+ * DDB firmware states.
+ */
+/* defined in ql4_fw.h
+#define DDB_DS_UNASSIGNED                       0x00
+#define DDB_DS_NO_CONNECTION_ACTIVE             0x01
+#define DDB_DS_DISCOVERY                        0x02

-ENOTUSED

+#define DDB_DS_NO_SESSION_ACTIVE                0x03

-ENOTUSED

+#define DDB_DS_SESSION_ACTIVE                   0x04
+#define DDB_DS_LOGGING_OUT                      0x05

-ENOTUSED

+#define DDB_DS_SESSION_FAILED                   0x06
+#define DDB_DS_LOGIN_IN_PROCESS                 0x07
+*/
+
+/*
+ * DDB flags.
+ */
+#define DF_RELOGIN		0	/* Relogin to device */
+#define DF_NO_RELOGIN		1	/* Do not relogin if IOCTL logged it out */
+#define DF_ISNS_DISCOVERED	2	/* Device was discovered via iSNS */
+#define DF_FO_MASKED		3

-ENOTUSED

+#define DF_RESET_NEEDED		4

-ENOTUSED

+#define DF_PERSISTENT_BOUND	5

-ENOTUSED

+#define DF_TAPE_PRESENT		6

-ENOTUSED

+#define DF_CONFIG_DEVICE        7

-ENOTUSED

+#define DF_RESCAN_NEEDED	8

-ENOTUSED

+/*
+ * DDB port type.
+ */
+typedef enum { FCT_UNKNOWN, FCT_BROADCAST, FCT_INITIATOR, FCT_TARGET
+} ddb_port_type_t;

-ENOTUSED

+
+/*
+ * Asynchronous Event Queue structure
+ */
+typedef struct {
+	uint32_t mbox_sts[MBOX_AEN_REG_COUNT];
+} aen_t;
+
+
+/*
+ * ISP Initialization Control Block.
+ * Little endian except where noted.
+ */
+typedef struct {
+	uint16_t firmware_options;
+	uint16_t tcp_options;
+	uint8_t ip_address[IP_ADDR_LEN];
+	uint8_t isns_ip_address[IP_ADDR_LEN];
+	uint16_t isns_server_port_number;
+	uint8_t alias[32];
+	uint8_t name_string[256];
+	uint8_t heartbeat_interval;
+	uint8_t rsvd;
+} init_cb_t;

-ENOTUSED
These could also be marked with the __{le,be}xx where appropriate if
it gets reused.

+
+/*
+ * Linux Host Adapter structure
+ */
+typedef struct scsi_qla_host {
+	/* Linux adapter configuration data */
+	struct Scsi_Host *host;	/* pointer to host data */
+	uint32_t tot_ddbs;
+	unsigned long flags;
+
+#define AF_ONLINE		      0	/* 0x00000001 */
+#define AF_INIT_DONE		      1	/* 0x00000002 */
+#define AF_MBOX_COMMAND 	      2	/* 0x00000004 */
+#define AF_MBOX_COMMAND_DONE 	      3	/* 0x00000008 */
+#define AF_DPC_SCHEDULED	      5	/* 0x00000020 */
+#define AF_INTERRUPTS_ON	      6	/* 0x00000040 Not Used */
+#define AF_GET_CRASH_RECORD	      7	/* 0x00000080 */
+#define AF_LINK_UP		      8	/* 0x00000100 */
+#define AF_TOPCAT_CHIP_PRESENT	      9	/* 0x00000200 */
+#define AF_IRQ_ATTACHED	      	     10	/* 0x00000400 */
+#define AF_64BIT_PCI_ADDR	     11	/* 0x00000800 */
+	unsigned long dpc_flags;
+
+#define DPC_RESET_HA		      1	/* 0x00000002 */
+#define DPC_RETRY_RESET_HA	      2	/* 0x00000004 */
+#define DPC_RELOGIN_DEVICE	      3	/* 0x00000008 */
+#define DPC_RESET_HA_DESTROY_DDB_LIST 4	/* 0x00000010 */
+#define DPC_RESET_HA_INTR	      5	/* 0x00000020 */
+#define DPC_ISNS_RESTART	      7	/* 0x00000080 */
+#define DPC_ISNS_RESTART_COMPLETION   8	/* 0x00000100 */
+#define DPC_AEN			      9	/* 0x00000200 */
+#define DPC_CHECK_LUN			10	/* 0x00000200 */
+#define DPC_WAIT_TO_RELOGIN_DEVICE   11
+#define DPC_GET_DHCP_IP_ADDR	     15	/* 0x00008000 */
+
+	uint16_t        iocb_cnt;
+     	uint16_t        iocb_hiwat;
+
+	/* SRB cache. */
+#define SRB_MIN_REQ	128
+	mempool_t *srb_mempool;
+
+	/* pci information */
+	struct pci_dev *pdev;
+
+	/* isp_reg_t *reg; */
+	isp_reg_t __iomem *reg;	/* Base I/O address */
+	unsigned long pio_address;
+	unsigned long pio_length;
+#define MIN_IOBASE_LEN		0x100
+
+	uint16_t req_q_count;
+	uint8_t marker_needed;
+	uint8_t rsvd1;
+
+	unsigned long host_no;
+	unsigned long instance;
+
+	/* NVRAM registers */
+	eeprom_data_t *nvram;
+	spinlock_t hardware_lock ____cacheline_aligned;
+	spinlock_t list_lock;
+	uint32_t   eeprom_cmd_data;
+
+	/* Counters for general statistics */
+	uint64_t adapter_error_count;
+	uint64_t device_error_count;
+	uint64_t total_io_count;
+	uint64_t total_mbytes_xferred;
+	uint64_t link_failure_count;
+	uint64_t invalid_crc_count;
+	uint32_t spurious_int_count;
+	uint32_t aborted_io_count;
+	uint32_t io_timeout_count;
+	uint32_t mailbox_timeout_count;
+	uint32_t seconds_since_last_intr;
+	uint32_t seconds_since_last_heartbeat;
+	uint32_t mac_index;
+
+	/* Info Needed for Management App */
+	/* --- From GetFwVersion --- */
+	uint32_t firmware_version[2];
+	uint32_t patch_number;
+	uint32_t build_number;
+
+	/* --- From Init_FW --- */
+	/* init_cb_t *init_cb; */
+	uint16_t firmware_options;
+	uint16_t tcp_options;
+	uint8_t ip_address[IP_ADDR_LEN];
+	uint8_t subnet_mask[IP_ADDR_LEN];
+	uint8_t gateway[IP_ADDR_LEN];
+	uint8_t isns_ip_address[IP_ADDR_LEN];
+	uint16_t isns_server_port_number;
+	uint8_t alias[32];
+	uint8_t name_string[256];
+	uint8_t heartbeat_interval;
+	uint8_t rsvd;
+
+	/* --- From FlashSysInfo --- */
+	uint8_t my_mac[MAC_ADDR_LEN];
+	uint8_t serial_number[16];
+
+	/* --- From GetFwState --- */
+	uint32_t firmware_state;
+	uint32_t board_id;
+	uint32_t addl_fw_state;
+
+	/* Linux kernel thread */
+	struct task_struct *dpc_thread;
+	uint8_t dpc_active;	/* DPC routine is active */
+
+	/* Linux timer thread */
+	struct timer_list timer;
+	uint32_t timer_active;
+
+	/* Recovery Timers */
+	uint32_t port_down_retry_count;
+	uint32_t discovery_wait;
+	atomic_t check_relogin_timeouts;
+	uint32_t retry_reset_ha_cnt;
+	uint32_t isp_reset_timer;	/* reset test timer */
+	uint32_t nic_reset_timer;	/* simulated nic reset test timer */
+	int eh_start;
+	struct list_head free_srb_q;
+	uint16_t free_srb_q_count;
+	uint16_t num_srbs_allocated;
+
+	/* Active array */
+	srb_t *active_srb_array[MAX_SRBS];
+	uint16_t current_active_index;
+
+	/* DMA Memory Block */
+	void *queues;
+	dma_addr_t queues_dma;
+	unsigned long queues_len;
+
+#define MEM_ALIGN_VALUE	\
+	    ((max(REQUEST_QUEUE_DEPTH, RESPONSE_QUEUE_DEPTH)) * \
+	     sizeof(QUEUE_ENTRY))
+	/* request and response queue variables */
+	dma_addr_t request_dma;
+	QUEUE_ENTRY *request_ring;
+	QUEUE_ENTRY *request_ptr;
+	dma_addr_t response_dma;
+	QUEUE_ENTRY *response_ring;
+	QUEUE_ENTRY *response_ptr;
+	dma_addr_t shadow_regs_dma;
+	shadow_regs_t *shadow_regs;
+	uint16_t request_in;	/* Current indexes. */
+	uint16_t request_out;
+	uint16_t response_in;
+	uint16_t response_out;
+
+	/* aen queue variables */
+	uint16_t aen_q_count;	/* Number of available aen_q entries */
+	uint16_t aen_in;	/* Current indexes */
+	uint16_t aen_out;
+	aen_t aen_q[MAX_AEN_ENTRIES];
+
+	/* pdu variables */
+	uint16_t pdu_count;	/* Number of available aen_q entries */
+	uint16_t pdu_in;	/* Current indexes */
+	uint16_t pdu_out;
+	uint16_t pdu_active;
+	PDU_ENTRY *free_pdu_top;
+	PDU_ENTRY *free_pdu_bottom;
+	PDU_ENTRY pdu_queue[MAX_PDU_ENTRIES];
+
+	/* This mutex protects several threads to do mailbox commands
+	 * concurrently.
+	 */
+	struct mutex  mbox_sem;
+	wait_queue_head_t mailbox_wait_queue;
+
+	/* temporary mailbox status registers */
+	volatile uint8_t mbox_status_count;
+	volatile uint32_t mbox_status[MBOX_REG_COUNT];
+
+	/* local device database list (contains internal ddb entries) */
+	struct list_head ddb_list;
+
+	/* Map ddb_list entry by FW ddb index */
+	ddb_entry_t *fw_ddb_index_map[MAX_DDB_ENTRIES];
+} scsi_qla_host_t;
+
+#define ADAPTER_UP(ha) ((test_bit(AF_ONLINE, &ha->flags) != 0) && (test_bit(AF_LINK_UP, &ha->flags) != 0))
+typedef struct {
+	uint8_t ha_mac[MAX_HBAS][MAC_ADDR_LEN];
+} mac_cfgs_t;

-ENOTUSED

+
+/*
+ * Other macros
+ */
+#define to_qla_host(x)		((scsi_qla_host_t *) (x)->hostdata)
+#define ql4_printk(level, ha, format, arg...) \
+    dev_printk(level, &((ha)->pdev->dev), format, ## arg)
+
+/*---------------------------------------------------------------------------*/
+
+/* Defines for qla4xxx_initialize_adapter() and qla4xxx_recover_adapter() */
+#define PRESERVE_DDB_LIST	0
+#define REBUILD_DDB_LIST	1
+
+/* Defines for process_aen() */
+#define PROCESS_ALL_AENS	 0
+#define FLUSH_DDB_CHANGED_AENS	 1
+#define RELOGIN_DDB_CHANGED_AENS 2
+
+/* Defines for qla4xxx_take_hw_semaphore */
+#define NO_WAIT		0

-ENOTUSED

+#define WAIT_FOREVER	1

-ENOTUSED

+#define TIMED_WAIT	2

-ENOTUSED

+
+#include "ql4_version.h"
+#include "ql4_settings.h"
+#include "ql4_glbl.h"
+#include "ql4_dbg.h"
+#include "ql4_inline.h"
+
+#endif	/*_QLA4XXX_H */
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux