Re: [PATCH 2/3] Better log messages for PQ3 devs

[Kurt Garloff <garloff@xxxxxxx>]

Hi Matthew,

On Wed, Mar 29, 2006 at 01:30:09PM -0700, Matthew Wilcox wrote:
> On Wed, Mar 29, 2006 at 10:12:47PM +0200, Kurt Garloff wrote:
> >  		 */
> > -		SCSI_LOG_SCAN_BUS(3, printk(KERN_INFO
> > -					"scsi scan: peripheral qualifier of 3,"
> > -					" no device added\n"));
> > +		SCSI_LOG_SCAN_BUS(2, printk(KERN_INFO "scsi scan: periph.qual. of 3,"
> > +				" device %s not added\n",
> > +				sdev->sdev_gendev.bus_id));
> 
> You seem to be suffering from long-line-itis, probably as a result of
> too much exposure to ia64 code.  How about:a

Indeed, my terminals are all more than 80 chars wide these days :-)
If that's the only concern, I'm happy to address it.

Thx,
-- 
Kurt Garloff, Head Architect Linux R&D, Novell Inc.

Attachment: pgpTc3bjUxDLm.pgp
Description: PGP signature