Re: [PATCH 1/2] sas transport: ref count update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christoph,

Can I get your comment(s) on this change.

Mike Anderson <andmike@xxxxxxxxxx> wrote:
> Fix puts so that release functions will be called.
> 
> Signed-off-by: Mike Anderson <andmike@xxxxxxxxxx>
> 
>  drivers/scsi/scsi_transport_sas.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> Index: aic94xx-sas-2.6-patched/drivers/scsi/scsi_transport_sas.c
> ===================================================================
> --- aic94xx-sas-2.6-patched.orig/drivers/scsi/scsi_transport_sas.c	2006-03-22 13:22:22.000000000 -0800
> +++ aic94xx-sas-2.6-patched/drivers/scsi/scsi_transport_sas.c	2006-03-22 13:24:27.000000000 -0800
> @@ -406,8 +406,6 @@ struct sas_phy *sas_phy_alloc(struct dev
>  	if (!phy)
>  		return NULL;
>  
> -	get_device(parent);
> -
>  	phy->number = number;
>  
>  	device_initialize(&phy->dev);
> @@ -484,7 +482,7 @@ sas_phy_delete(struct sas_phy *phy)
>  	transport_remove_device(dev);
>  	device_del(dev);
>  	transport_destroy_device(dev);
> -	put_device(dev->parent);
> +	put_device(dev);
>  }
>  EXPORT_SYMBOL(sas_phy_delete);
>  
> @@ -990,7 +988,7 @@ sas_rphy_delete(struct sas_rphy *rphy)
>  
>  	parent->rphy = NULL;
>  
> -	put_device(&parent->dev);
> +	put_device(dev);
>  }
>  EXPORT_SYMBOL(sas_rphy_delete);

-andmike
--
Michael Anderson
andmike@xxxxxxxxxx
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux