On Thu, Mar 23 2006, Christoph Hellwig wrote: > On Thu, Mar 23, 2006 at 11:18:19AM +0100, Jens Axboe wrote: > > > the non-S/G I/O path. Jens, what do you think about adding a check > > > for non-S/G I/O in the midlayer? > > > > Looks good to me. Are cdrom/sr sg clean as well? > > there's just one place in cdrom.c that sends a request directly: > cdrom_read_cdda_bpc, which sends a S/G BLOCK_PC one. Everything else > goes through ->packet_command which is implemented as oldstyle-PC > requests in IDE and S/G BLOCK_PC in scsi. all scsi-internal requests > including those from sr are S/G of BLOCK_PC type. Ok thanks for confirming, then lets just add that non-sg check in the mid layer. -- Jens Axboe - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html