Re: [PATCH 05/15] libata: Add __ata_scsi_ioctl

[Jeff Garzik <jgarzik@xxxxxxxxx>]

Brian King wrote:
> Jeff Garzik wrote:
>
> > Brian King wrote:
> >
> > > -int ata_scsi_ioctl(struct scsi_device *scsidev, int cmd, void __user *arg)
> > > +int __ata_scsi_ioctl(struct scsi_device *scsidev, int cmd, void __user *arg)
> > > {
> > > -	struct ata_port *ap;
> > > -	struct ata_device *dev;
> > > 	int val = -EINVAL, rc = -EINVAL;
> > >
> > > -	ap = (struct ata_port *) &scsidev->host->hostdata[0];
> > > -	if (!ap)
> > > -		goto out;
> > > -
> > > -	dev = ata_scsi_find_dev(ap, scsidev);
> > > -	if (!dev) {
> > > -		rc = -ENODEV;
> > > -		goto out;
> > > -	}
> > > -
> > > 	switch (cmd) {
> >
> >
> > Rather than create a new function, it looks like the above code can 
> > simply be removed.  I don't see anything that uses 'ap' or 'dev'.
>
>
> Sounds good to me. Patch below.

ACK


-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html