[PATCH] remove generic symlink from sg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This has been redundant ever since James Smart added the class back
links since every scsi_device now gets one of these of the form
scsi_generic:sg<n>.

I'm open to going through the deprecated features business for this,
since this would represent a user visible change of the scsi sysfs
interface if you wish.

James

diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1471,11 +1471,6 @@ sg_add(struct class_device *cl_dev, stru
 			printk(KERN_WARNING "sg_add: "
 				"class_device_create failed\n");
 		class_set_devdata(sg_class_member, sdp);
-		error = sysfs_create_link(&scsidp->sdev_gendev.kobj, 
-					  &sg_class_member->kobj, "generic");
-		if (error)
-			printk(KERN_ERR "sg_add: unable to make symlink "
-					"'generic' back to sg%d\n", k);
 	} else
 		printk(KERN_WARNING "sg_add: sg_sys INvalid\n");
 
@@ -1544,7 +1539,6 @@ sg_remove(struct class_device *cl_dev, s
 	write_unlock_irqrestore(&sg_dev_arr_lock, iflags);
 
 	if (sdp) {
-		sysfs_remove_link(&scsidp->sdev_gendev.kobj, "generic");
 		class_device_destroy(sg_sysfs_class, MKDEV(SCSI_GENERIC_MAJOR, k));
 		cdev_del(sdp->cdev);
 		sdp->cdev = NULL;


-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux