On Fri, 2006-03-17 at 21:30 +0100, Stefan Richter wrote: > the following drivers use [__]scsi_add_device/ scsi_remove_device: The rule is that scsi_add_device() doesn't leave you with a reference, but __scsi_add_device() does. scsi_remove_device() does just that, but it doesn't put any references you might have taken separately. > But aacraid and mptsas call scsi_add_device + scsi_remove_device + > scsi_device_put. AFAICS this is either one scsi_device_put too many or > one scsi_device_get too few. These all look correct. The scsi_device_puts are paired with scsi_device_lookup() which does indeed get a reference which needs putting. James - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
