On Tue, Mar 14, 2006 at 05:08:55PM +0000, Christoph Hellwig wrote: > On Tue, Mar 14, 2006 at 07:34:55AM -0800, Greg KH wrote: > > Also, it looks like USB needs to call this function, (based on the > > comment)? Care to switch that code over to have it use it too? > > what comment do you think indicates that? It's needed for raid drivers > that I saw the: + if (dev->driver) {^M + if (dev->parent) /* Needed for USB */^M + down(&dev->parent->sem);^M portion and thought it came from USB core code somewhere. Or are you referring to the need for USB-storage here? > > a) expose physical volumes but set the no_uld_attach flag to hide them > from sd > b) allow only raid volume creation/deletion so this flag may be set/cleared > at runtime Ok, fair enough, just was a bit confused. thanks, greg k-h - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html