>>On Thu, 2006-03-02 at 14:52 -0800, Arjan wrote: >On Thu, 2006-03-02 at 14:52 -0800, Ravi Anand wrote: > All, > > For the upstream inclusion of qla4xxx driver, following files : > - Updated driver source (qla4xxx-src-v5.00.05b4-k_submit.tar.bz2) >>another thing: + set_current_state(TASK_UNINTERRUPTIBLE); + schedule_timeout(10); >>this is obviously a bug.. for which HZ value is that 10? >>I think you really want to use msleep() instead here, which uses >>wallclock time units, and does the state setting for you as well. >>(and is generally a nicer albeit simpler API than schedule_timeout() ) Agreed. We will switch to msleep(). Ravi - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
