From: Adrian Bunk <bunk@xxxxxxxxx> I don't see any reason for __gdth_execute() being global. Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx> Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/scsi/gdth.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff -puN drivers/scsi/gdth.c~drivers-scsi-gdthc-make-__gdth_execute-static drivers/scsi/gdth.c --- devel/drivers/scsi/gdth.c~drivers-scsi-gdthc-make-__gdth_execute-static 2006-03-08 00:13:05.000000000 -0800 +++ devel-akpm/drivers/scsi/gdth.c 2006-03-08 00:13:05.000000000 -0800 @@ -692,8 +692,8 @@ static void gdth_scsi_done(struct scsi_c complete(scp->request->waiting); } -int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, char *cmnd, - int timeout, u32 *info) +static int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, + char *cmnd, int timeout, u32 *info) { struct scsi_request *scp = scsi_allocate_request(sdev, GFP_KERNEL); unsigned bufflen = gdtcmd ? sizeof(gdth_cmd_str) : 0; @@ -726,8 +726,8 @@ static void gdth_scsi_done(Scsi_Cmnd *sc complete(scp->request.waiting); } -int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, char *cmnd, - int timeout, u32 *info) +static int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, + char *cmnd, int timeout, u32 *info) { Scsi_Cmnd *scp = scsi_allocate_device(sdev, 1, FALSE); unsigned bufflen = gdtcmd ? sizeof(gdth_cmd_str) : 0; _ - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html