--- James Bottomley <James.Bottomley@xxxxxxxxxxxx> wrote: > This one actually does the end devices, since that's all I really have > to work with in my setup. However, I can do the expanders in the same > way. *************************************************************************** > The idea is to make the rphy embedded in the enveloping device > structure, so the code which doesn't care about type can still treat the > code as a simple rphy, and the code that does care can cast out to the > device type. *************************************************************************** James, this doesn't make sense in SAS. Maybe you're implementing some other protocol, but what you have here isn't SAS. You need to understand what a port is and what a phy is. Then you need to understand their (mutual) interactions. What each one represents (or doesn't) and their dependencies. Then you need to understand why you don't want to represent any of those two concepts for anything past your own ports. True, it's all open sourced in the complete SAS Stack, but reverse-engineering the logic isn't easy without studying the SAS spec. > If everyone's OK with this, I'll do expanders next. Please don't. They are done already, sas_expander.c is the file. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html