On Friday, March 03, 2006 4:42 AM, Christoph Hellwig wrote: > On Thu, Mar 02, 2006 at 04:01:31PM -0600, James Bottomley wrote: > > aic94xx doesn't have a use for the bay or enclosure identifiers. > > Also, I think it's not going to need a get_linkerrors(), so wire up > > all of these exported properties as conditional on the underlying > > function support. > > Making these optional is okay. > > the expander identifier is part of the SMP REPORT_GENERAL > reply, so aic94xx > should be able to support it easily. Similarly I'm pretty > sure it supports > link error statistics aswell. > Optional, humm.... ?? These are defined here: Enclosure Logical ID is SAS 1.1 spec, as SMP REPORT_GENERAL (opcode = 0x40, fuction = 0x0) The slot/bay indentifier should be in SES-II spec. Link Statistics is in SAS 1.1 spec, as SMP REPORT_PHY_ERROR_LOG (opcode = 0x40, fuction = 0x11) Link Reset and Hard Reset is in SAS 1.1 spec, as in SMP PHY_CONTROL (opcode = 0x40, function = 0x91) Eric Moore - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html