Looks good by me, save that it would be nicer to use either AAC_DRIVERNAME or aac->name instead of yet another hard coded string. Eg: > - aac->thread_pid = kernel_thread((int (*)(void *))aac_command_thread, > - aac, 0); > - if (aac->thread_pid < 0) { -> + aac->thread = kthread_run(aac_command_thread, aac, "aacraid"); +> + aac->thread = kthread_run(aac_command_thread, aac, AAC_DRIVERNAME); > + if (IS_ERR(aac->thread)) { > printk(KERN_ERR "aacraid: Unable to create command thread.\n"); Sincerely -- Mark Salyzyn - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html