On Sun, Feb 12, 2006 at 06:35:24PM +0100, Thomas Maguin wrote: > On Sunday 12 February 2006 17:53, you wrote: > > The trouble is that these are vendor-specific commands. So they're safe > > *for plextor devices*, but they may well be unsafe for other vendors. > > > These are just read commands. A correct firmware should just reject the > commands. I don't think you understand the point. A non-Plextor device could have a HALT AND CATCH FIRE command on that opcode. That definitely wouldn't be safe. If 'just a read command' were enough, we wouldn't need to have filtering for read commands at all. > Plextor users have been waiting a long time for the features in linux, so > please think about a solution which is a solution for all users. The only solutions I can think of are big and ugly if they're in the kernel. Why not write a set-uid helper that checks the device manufacturer and device type, then issues the appropriate command? That would work on 2.4 as well as 2.6. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html