On Thu, Feb 09, 2006 at 10:00:52PM -0500, Alan Stern wrote: > On Thu, 9 Feb 2006, Patrick Mansfield wrote: > Which BLIST bits exactly are per-target? Obviously everything with LUN in > the name and probably the two INQUIRY flags. Anything else? Per other posts and whether the vendor and product can change across LU's on a given target, they could all be per-target, but we can't assume that. I didn't audit the BLIST values. > > IMO store them all in sdev_bflags for now. > > In fact, the sdev_bflags and the starget_bflags can be copies of each > other (subject to modification by the host adapter driver, of course). I > think the accessors should be inline routines, so they can do > type-checking on the argument (scsi_device vs. scsi_target). I was thinking that too, but then you have to get values out of the sdev flags, and don't need starget flags except to pass bflags around during scan. So, just use a per sdev flag. > Do you mind if I don't bother to write setter routines? I don't care. hch or James? I think they would only be used by host drivers or transports, as the scan would set sdev_bflags = scsi_get_device_flags(). -- Patrick Mansfield - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
