On Tue, Feb 07, 2006 at 10:06:27PM -0800, Andrew Morton wrote: >... > Changes since 2.6.16-rc1-mm5: >... > +gdth-add-execute-firmware-command-abstraction.patch > > scsi driver API modernisation >... I don't see any reason for __gdth_execute() being global. Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx> --- drivers/scsi/gdth.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- linux-2.6.16-rc2-mm1-full/drivers/scsi/gdth.c.old 2006-02-10 00:49:53.000000000 +0100 +++ linux-2.6.16-rc2-mm1-full/drivers/scsi/gdth.c 2006-02-10 00:51:05.000000000 +0100 @@ -693,8 +693,8 @@ complete(scp->request->waiting); } -int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, char *cmnd, - int timeout, u32 *info) +static int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, + char *cmnd, int timeout, u32 *info) { struct scsi_request *scp = scsi_allocate_request(sdev, GFP_KERNEL); unsigned bufflen = gdtcmd ? sizeof(gdth_cmd_str) : 0; @@ -727,8 +727,8 @@ complete(scp->request.waiting); } -int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, char *cmnd, - int timeout, u32 *info) +static int __gdth_execute(struct scsi_device *sdev, gdth_cmd_str *gdtcmd, + char *cmnd, int timeout, u32 *info) { Scsi_Cmnd *scp = scsi_allocate_device(sdev, 1, FALSE); unsigned bufflen = gdtcmd ? sizeof(gdth_cmd_str) : 0; - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html