Christoph Hellwig wrote: > On Tue, Feb 07, 2006 at 08:52:50AM +0100, Hannes Reinecke wrote: >> This patch converts platform_data->qfrozen to atomic_t. >> This way we can get rid of ahd_lock / ahd_unlock for the >> accessor functions; it also fixes some deadlocks in the >> recovery code (again). > > While we're at it there's also a qfrozen variable in the ahd_linux_device > structure. Since the driver lost it's internal queueing it and the > surrounding core are totally unused. > Not quite sure (yet) whether we can do this. dev->qfrozen is also used during error recovery to prevent the SCB being reused accidentally. And as the error recovery is totally buggered anyway I'm loath to dead-fix it even more. I'll have to investigate that. But the platform->qfrozen flag can indeed be removed. Just calling scsi_block_request() is enough here. Cheers, Hannes -- Dr. Hannes Reinecke hare@xxxxxxx SuSE Linux Products GmbH S390 & zSeries Maxfeldstraße 5 +49 911 74053 688 90409 Nürnberg http://www.suse.de - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
