--- James Bottomley <James.Bottomley@xxxxxxxxxxxx> wrote: > On Thu, 2006-01-26 at 21:22 -0800, Luben Tuikov wrote: > > Introduce scsi_req_abort_cmd(struct scsi_cmnd *). > > This function requests that SCSI Core start recovery for the > > command by deleting the timer and adding the command to the eh > > queue. It can be called by either LLDDs or SCSI Core. LLDDs who > > implement their own error recovery MAY ignore the timeout event if > > they generated scsi_req_abort_cmd. > > In theory, the code to do this already exists: the current way to > achieve this is supposed to be to return a status of DID_TIME_OUT to the > command, which triggers error recovery. The only difference between > this and what you propose is that the eh_timed_out API won't get called > (presumably OK since the LLD already knows it wishes to trigger the > error handler) and that the error handler will begin at the device reset > task management function (again, on the assumption that the LLD cleaned > everything up before returning DID_TIME_OUT). Is that sufficient for > your purpose or do we really need another API? No, it is not sufficient. Yes, you really do need another API. Luben - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
