On Thursday, January 26, 2006 12:35 PM, Christoph Hellwig wrote: > The port identifier for a given phy could change when phys > are removed from > one port and added to another. So doing this for the phy is probably > a bad idea. Doing it for the rphy should be fine because > that object gets > removed and recreated in that case. > Agreed, that makes sense. Here is new patch with only rphy displaying the port_identifier. Signed-off-by: Eric Moore <Eric.Moore@xxxxxxxx> --- b/drivers/scsi/scsi_transport_sas.c 2006-01-18 10:07:05.000000000 -0700 +++ a/drivers/scsi/scsi_transport_sas.c 2006-01-26 15:52:38.000000000 -0700 @@ -377,7 +377,7 @@ /** * sas_phy_alloc -- allocates and initialize a SAS PHY structure * @parent: Parent device - * @number: Port number + * @number: Phy index * * Allocates an SAS PHY structure. It will be added in the device tree * below the device specified by @parent, which has to be either a Scsi_Host @@ -595,8 +595,8 @@ device_initialize(&rphy->dev); rphy->dev.parent = get_device(&parent->dev); rphy->dev.release = sas_rphy_release; - sprintf(rphy->dev.bus_id, "rphy-%d:%d", - shost->host_no, parent->number); + sprintf(rphy->dev.bus_id, "rphy-%d:%d-%d", + shost->host_no, parent->port_identifier, parent->number); transport_setup_device(&rphy->dev); return rphy; - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
