Re: [PATCH: dc395x] "fix" virt_addr calculation on AUTO_REQSENSE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 20 Jan 2006, Guennadi Liakhovetski wrote:

> The patch below "fixes" calculation of the virt_addr for the AUTO_REQSENSE 
> case. I put "fixes" in quotes because the real fix would be to completely 
> remove it, but that's beyond the scope of this patch.

Just wanted to comment a bit what the actual problem is. As this bug 
triggers you get "sg_update_list: sg_to_virt failed" KERN_ERR from the 
driver. And virt_addr is set to NULL. Which is in most cases not a 
problem, because it is only used in PIO tranfers. And we currently don't 
know of any dc395x users triggering PIO. But if there were one, and the 
very sense request where this bug triggered got transferred in PIO mode, 
it would Oops. For the rest, you just get your logs filled with the 
"harmless" message. E.g., I had something like

dc395x: sg_update_list: sg_to_virt failed
last message repeated 600 times

:-)

Thanks
Guennadi
---
Guennadi Liakhovetski
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux