Re: [PATCH 04/15] qla2xxx: Use msleep() as delay during ISP polling.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 14 Jan 2006, Arjan van de Ven wrote:

> > -			udelay(10); /* v4.27 */
> > +			msleep(10);
> 
> this goes from a 10 microsecond delay to a 10 milisecond delay. Was that
> intentional?

the original (original) code was:

	...
	set_current_state(TASK_UNINTERRUPTIBLE);
	schedule_timeout(10);

during upstream development it was changed (incorrectly) to:

	udelay(10);


again, the qla2xxx driver only uses this poll-for-completion mechanism
during init-time.  There really is (was) no reason to bang on the chip
in such a tight-loop.

Thanks,
Andrew
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux