On Fri, Jan 13, 2006 at 09:55:47AM -0600, James Bottomley wrote: > On Fri, 2006-01-13 at 11:09 +0100, Christoph Hellwig wrote: > > + struct semaphore sas_topology_mutex; > > The semaphore to mutex conversion squad will have me shot if I put that > in. If it's just a mutex, then you need to use the new mutex types. If > it's actually a real counting semaphore (which it doesn't look to be) > then call it a semaphore. well, the scsi-misc tree doesn't have the mutex code yet, so it wouldn't compile if I did it that way. I'll send a followon patch to convert it to use real mutexes ones scsi-misc has merged the latest linus tree. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html