On 09.01.2006 20:04 James Smart <James.Smart@xxxxxxxxxx> wrote: > Christoph Hellwig wrote: > > Actually I think even for Xen-like virtualization it makes most sense that > > most domains wouldn't see the Scsi_Host for the phyisical port so this solution > > looks most sane to me. The long name for the physical names sounds fine to me > > as well, much better than un-understandable three-latter acronyms :) [... snip ...] > Having made this argument - I then said - why not use the name from the > standards, "permanent_port_xxx". But, when I look at this, it's not much > different. Permanent vs Physical ? at least the abbreviation gave it some > separation. Bah Humbug. My preference is still "permanent" over "physical" > as it tracks the standards name. I think physical_port_name was not the right choice. Sticking to standards the name should be permanent_port_name. So people familiar with FC standards have an idea what it is and all others are able to find an explanation in FC-GS-4. But introducing a permanent_port_id will lead to confusion: Interpretation as "permanent port_id" is wrong because a port_id is anything but "permanent". In conclusion James' suggestion of attributes ppn and ppn_id has some advantage. And now comes the funny part: Question is, do I need the port_id of the physical port at all? In order to determine problems with a virtual port I might have to check whether the physical port is properly connected and logged in to the fabric. Furthermore configuration of the corresponding switch port should be checked. (E.g. switch might allow to set limits for the number of NPIV connections for the switch port.) I may be wrong but I think the port_id of the physical port is not needed for this purpose. Thus, how about introducing just what is really needed: Introduce permanent_port_name attribute (and leave out port_id of the physical port). BTW, the permanent_port_name attribute of the virtual port suffices to identify the fc_host of the physical port if there is a representation. And I think an LLDD should configure this attribute only for virtual ports. Regards, Andreas - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
