On Sat, Dec 10, 2005 at 03:05:41PM +0100, Stefan Richter wrote: > I learned now of many more points which set the transfer direction. It > can apparently even come from userspace. It can be specified with sg. > >I also wonder if there could ever be something else execpt DMA_NONE, > >DMA_TO_DEVICE, or DMA_FROM_DEVICE being passed to sbp2. If it is > >guaranteed that scsi_cmnd.sc_data_direction is one of these three, we > >should remove ieee1394/sbp2.h::sbp2scsi_direction_table[]. > > AFAIU it is still possibly that DMA_BIDIRECTIONAL is passed down. > However I think now that we should delete sbp2scsi_direction_table > anyway and simply reject DMA_BIDIRECTIONAL. This is what a few other > SCSI low-level drivers do, and I think it is appropriate for a low-level > driver to fail such commands instead of converting them to a "known" > direction. Yes, please. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
