On Sat, Dec 10, 2005 at 09:48:33AM +0100, Jens Axboe wrote: > On Fri, Dec 09 2005, Stefan Richter wrote: > > scsi: dont allow DMA_TO_DEVICE with zero data length > > > > When preparing a request in scsi_lib or in a SCSI high-level driver, > > always set a transfer direction of DMA_NONE if data length is zero, > > even for alleged write requests. (Extended patch derived from Jens > > Axboe's version.) > > > > Write requests with request buffer length == 0 lead to kernel panic > > or oops if channeled through sbp2: > > http://marc.theaimsgroup.com/?l=linux1394-devel&m=113399994920181 > > http://marc.theaimsgroup.com/?l=linux1394-user&m=112152701817435 > > > > Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> > > My quick grep just showed the one, I'd encourage you to turn this into a > static inline function instead of duplicating the same code again 3 (or > more) times. Actually Mike has code pending to remove all copies but the scsi_lib.c one. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
