On 12/9/05, Jeff Garzik <jgarzik@xxxxxxxxx> wrote: > Yes, I do agree with this WRT PATA. Randy Dunlap's ACPI stuff is > particularly interesting for this, though I haven't had time to review > it in depth. > > I'm a bit more reluctant WRT SATA. (side note: Shaohua's patch added ACPI support to PATA. Randy's was the SATA ACPI support.) ACPI 3.0 specifically mentions SATA and the control methods that it expects the OS to make use of: _SDD and _GTF. This is needed for things like HD password unlocking. So, someone needs to be handling this whenever the SATA drive is reinitialized, such as on resume. So there's gotta be some SATA ACPI code, somewhere. (And if there is, then handling the ICH5 ACPI hotplug interrupt seems like maybe something it should handle, too.) I'm sure it's possible to properly abstract things so that arch-neutral code can remain ACPI-unaware -- I just wanted to make it clear that even if you don't support ICH5 hotplug there are still ACPI requirements for SATA. Regards -- Andy - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
