Jody McIntyre wrote:
On Fri, Dec 09, 2005 at 08:01:11PM +0100, Stefan Richter wrote:
If all *known* paths are fixed, we could consider to override a bad
transfer direction silently like e.g. usb_storage does. But we should
not leave sbp2_create_command_orb() as fragile as it currently is.
I didn't know USB did this.. the fact that USB checks itself suggests
that we also need a check, and if we're checking we may as well warn.
Well, usb_storage actually does not override it explicitly. It just acts
only on DMA_FROM_DEVICE or DMA_TO_DEVICE after having first checked for
transfer buffer length AFAIU. However this is just one example. It
differs between SCSI low level drivers. I don't know if any of them logs
warnings about suspect transfer directions.
--
Stefan Richter
-=====-=-=-= ==-- -=--=
http://arcgraph.de/sr/
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
