I wrote:
Andrew de Quincey wrote:
USB storage devices still work with the CDROMEJECT ioctl and this
change as well.
I'll check if they have a safeguard which sbp2 should have too.
I browsed a bit through usb/storage/ but did not spot an obvious sanity
check of this kind. AFAIU, slightly differently arranged case
discriminations let usb-storage avoid this pitfall.
Your patch to sbp2_create_command_orb() is basically the right thing to
do --- not as an actual fix of the bogus transfer direction passed to
sbp2 but rather as a protection against catastrophic failure. I'd like
to integrate your check in marginally different form though. Patch
follows shortly.
Thanks again.
--
Stefan Richter
-=====-=-=-= ==-- -=---
http://arcgraph.de/sr/
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
