On Wed, Nov 23, 2005 at 02:50:00PM -0800, Chen, Kenneth W wrote: > I'm proposing the following patch to optimize scsi_cmnd initialization. > The only part that I'm not 100% sure is struct scsi_pointer SCp and > eh_eflags. It appears to be safe, but since I don't have every scsi > controllers in the world to test, I can't say so for sure. I'm willing > to take on the responsibility to fix any hiccup people might have with > this patch. Comments? SCp should be zeroed, it's the scratch area for controllers. eh_ehflags is under midlayer control and should start out as zero. > p.s. de-referencing jiffies_at_alloc ought be in the if(cmd!=NULL) block. that's fixed already in latest mainline. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html