Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] sez: > Just checking for channel 0 is fine with me, although a > > #define AAC_RAID_CHANNEL 0 The 'documentation' of this used to be embedded in a Macro that was recently removed to prepare for SAS. I'll keep this in mind, I am starting to build up a few 'cleanup' items, held back because we still have some meaty patches coming up. > Similar issue is the tagged_supported check, it's totally magic to me and at > least needs a very good comment. Should not be magic, if the device has tagging turned/forced/quirked off, then we must ensure that scsi_adjust_queue_depth(sdev,0,1) be the only value submitted; certainly not setting a larger queuedepth. Sincerely -- Mark Salyzyn - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
