There's a couple of other references that can be removed as well.
Rather than back this out of the patch - we'll submit another short patch
which addresses this comment. Patch is done, just need to quickly test it.
Please note: there will be 2 other areas where we will still be accessing
config space:
- We need the bar value, as the hardware sees it, to program a base
address it can decode to keep ring accesses on-chip. The current pci
infrastructure doesn't provide this. (we've talked about this on this
reflector before).
- If we reset the card, there were hardware-isms that may erroneously
drive perr/serr. So, we need to temporarily turn them off while we
reset. (I believe we went through this as well on this list early on).
-- james
> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx]
> Sent: Monday, November 28, 2005 11:52 AM
> To: Smart, James
> Cc: linux-scsi@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 7/11] lpfc 8.1.1 : Add support for more members of
> the Light Pulse 11xxx (4Gb) family
>
>
> On Mon, Nov 28, 2005 at 11:42:12AM -0500,
> James.Smart@xxxxxxxxxx wrote:
> > - pci_read_config_dword(phba->pcidev, PCI_VENDOR_ID, &id);
> > + pci_read_config_word(phba->pcidev, PCI_DEVICE_ID, &dev_id);
>
> please don't read the pci id directly, alway use pdev->device
>
>
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
