On Sun, Nov 27, 2005 at 07:52:52PM +0100, Adrian Bunk wrote: > On Sun, Nov 27, 2005 at 10:47:38AM -0200, Marcelo Tosatti wrote: > > On Sun, Nov 27, 2005 at 12:36:37AM +0100, Adrian Bunk wrote: > > > The Coverity checker spotted this obvious NULL pointer dereference. > > > > Hi Adrian, > > Hi Marcelo, > > > Could you explain why you remove the adpt_post_wait_lock acquision? > > > > And if it does not belong there, why don't you remove it instead of > > commeting out? > >... > > my patch does remove the following not required line: > > > > - p2 = NULL; > > It does not touch the following line that was already commented out: > > > > // spin_lock_irqsave(&adpt_post_wait_lock, flags); > >... Doh. I should _read_ the patch. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
