On 11/16/05, Jens Axboe <axboe@xxxxxxx> wrote: > I updated that patch, and converted IDE and SCSI to use it. See the > results here: > > http://brick.kernel.dk/git/?p=linux-2.6-block.git;a=shortlog;h=blk-softirq I like it but: * "we know it's either an FS or PC request" assumption in ide_softirq_done() is really wrong * same with "uptodate = rq->errors" * blk_complete_request() is called with ide_lock hold but ide_softirq_done() also takes ide_lock - is this correct? "There's still room for improvement, as __ide_end_request() really could drop the lock after getting HWGROUP->rq (why does it need to hold it in the first place? If ->rq access isn't serialized, we are screwed anyways)." ide_preempt? and yes we are screwed... Bartlomiej - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
