On Sun, 2005-11-13 at 14:42 -0500, Doug Ledford wrote: > The device is on a non-LVD bus. Certain devices were created back when > the spec still stated that using PPR negotiation messages on a non-LVD > bus was a no-no. As the echo buffer was an addition to support DV, and > originally DV wasn't intended to be used on non-LVD busses, it might > stand to reason that this device simply is going tits up because we are > attempting to use the echo buffer while in SE mode. Checking that > PPR/DT is valid (not just between controller and device, but also given > bus mode) and only using echo buffer DV when all LVD conditions are met > would likely solve the problem (assuming that the problem is what you > are referring to). I think so (pending confirmation of the patch working). The current DV code assumes that if the device claims DT support in the INQUIRY data *and* it returns a valid descriptor to the READ_BUFFER descriptors command then enhanced DV should be attempted. What I'm contemplating doing (which is what you also suggest) is tightening up the check so if the standard DV read tests produce a negotiation that doesn't set DT then we won't attempt enhanced DV James - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
