On Fri, Nov 04, 2005 at 12:33:50PM -0600, James Bottomley wrote: > On Fri, 2005-11-04 at 09:28 -0800, Matthew Dharm wrote: > > > I've no distinct recollection of someone removing this, but if I > > > remember correctly what it used to do, it was a hack to stop us from > > > mangling SCSI-3 CDB's. We fixed the mid-layer not to require the hack > > > by only setting the CDB[1] lun field for SCSI-1 and SCSI-2 devices (as > > > the standards mandate). What's the actual problem? No SCSI-1 or SCSI-2 > > > device should have any vendor specific CDBs that uses these bits in > > > CDB[1]. > > > > Unfortunately, reality appears to disagree with the last "should". I've > > personally seen devices with vendor-specific commands that want to control > > CDB[1] in SCSI-2. > > > I didn't know it was removed; I only know what Timothy Thelin told me. Can > > we get the feature back? > > Not at all easily ... changes to support it would have to thread through > several structures in both the block layer and the scsi subsystem. Would the block layer really have to change much if the commands only come from SG_IO? Matt -- Matthew Dharm Home: mdharm-usb@xxxxxxxxxxxxxxxxxx Maintainer, Linux USB Mass Storage Driver P: How about "Web Designer"? DP: I'd like a name that people won't laugh at. -- Pitr and Dust Puppy User Friendly, 12/6/1997
Attachment:
pgpWvRG0bAdaL.pgp
Description: PGP signature
