Christoph> No. Bitfields for accessing hardware/wire Christoph> datastructures are wrong and will always break in some Christoph> circumstances. Your header is much better. OK, that's my feeling as well. Would it make sense for me to split the pure SRP spec structures and so on into a separate file and put it in include/scsi/srp.h? Then we can move ibmvscsi towards using that file. - R. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html