OK, I'm convinced. I will re-do the ips patch, eliminate the error checking, and use kmap_atomic(). The patch should be small, but since this is in the main I/O path, the skeptic in me says to stress the changes I make thoroughly under both the 2.4 and 2.6 kernels. So it may be a couple days before I post an updated patch. -----Original Message----- From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] Sent: Thursday, October 20, 2005 1:40 PM To: Salyzyn, Mark Cc: IpsLinux; Christoph Hellwig; Matthew Wilcox; akmpm@xxxxxxxx; James.Bottomley@xxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx Subject: Re: ips.c warnings On Thu, Oct 20, 2005 at 01:38:30PM -0400, Salyzyn, Mark wrote: > Jack, do not forget legacy kernels. Christoph is notorious for dealing > only with latest kernel only. > > Christoph, has this always been true? I believe it to be, but just in > case ... For mainline this was always true. OTOH Adaptec is notorious for supporting very odd non-standard kernels, so who knows ;-) - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
