Sounds good to me. That's easy enough to do. I was just hesitant to take out an error check ( in code I didn't originate ) without a 100% guarantee that it's OK without it. I'll send a new patch and totally eliminate the checks and extra macros ... Thanks. -----Original Message----- From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] Sent: Thursday, October 20, 2005 1:29 PM To: Hammer, Jack Cc: Matthew Wilcox; akmpm@xxxxxxxx; James.Bottomley@xxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; IpsLinux Subject: Re: ips.c warnings On Thu, Oct 20, 2005 at 01:25:28PM -0400, Hammer, Jack wrote: > > I have no problem trying kmap_atomic() as long as there's a sound, > technical reason for changing code that's worked well for years. > > What are the advantages/reasons of changing to use kmap_atomic() ? It > appears very few SCSI drivers use it. I think the real question is: what are these checks for. You should never get an SG list with a NULL struct page or an SGL entry that points to address 0 from the higher level code, and no other drivers checks for that condition. - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
