On Sat, 15 Oct 2005, Douglas Gilbert wrote: > Alan, > In include/scsi/scsi_eh.h there are several helper functions > to aid processing SCSI errors. This includes SCSI sense data > descriptor format (which won't be needed for DVD/HD/BD for > some time with a (2**32 * 2048) byte maximum using existing > fixed sense data format). However there is > scsi_get_sense_info_fld() to fetch the info field. > > sd, st and sg have been converted to use these helpers, > where appropriate. > > MMC-4 does not mention that the valid bit needs to > be set on a MEDIUM/HARDWARE error and I have seen > real life examples of this. [So it's poorly defined > if one gets a medium error on lba 0.] You may also like to > consider deferred errors which can occur according to > MMC-4. Thanks for the comments. It will be easiest to start with this patch and then add others on top. I wouldn't mind writing another update to use scsi_get_sense_info_fld and friends. I'm not familiar with the MMC standards and it will take some time to get up to speed on MMC-4. I just downloaded the draft standard, and it's not obvious where (if anywhere) it describes the sense data values. As for deferred errors, I don't know the proper way of handling them. It would be better for someone else to take care of it. Alan Stern - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html