On Fri, 14 Oct 2005, James Bottomley wrote: > On Fri, 2005-10-14 at 12:58 -0400, Alan Stern wrote: > > (b) The bizarre line that said > > > > error_sector &= ~(block_sectors - 1); > > > > is now gone. Do you know what that was intended to do? > > It's not a bizzare line ... it's rounding down to our current set block > size. That was the difference I noticed in the reporting. The bio > layer maintains a separate sector size from the actual device, so if the > error occurs in the middle of a block sector (because block sectors > > hard sectors) then we report as though it occurred at the beginning of > the block sector. I see. I didn't understand the relation between bio->bi_size and anything else. It wasn't clear that this size is always equal to a block-layer sector size, as opposed to an arbitrary memory buffer size. I will send a revised patch shortly. Alan Stern - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
