On Thursday, October 13, 2005 12:15 PM, Grant Grundler wrote: > > Eric, > Minor cleanup to the error handling in mpt_attach. > Intent is to make this code a bit more maintainable. Thanks, nice cleanup. > I'm also wondering if pci_disable_device() should be added to > the error handling code. > I guess that sounds good adding pci_disable_device(). Can you resend with patch that handles this(failure of pci_set_dma_mask, and the kmalloc right below it); as well as calling pci_disable_device() from mpt_detach() ? > +mpterr_freeirq: > + free_irq(ioc->pci_irq, ioc); > +mpterr_listdel: > + list_del(&ioc->list); > + iounmap(mem); > +mpterr_freeioc: > + kfree(ioc); > + pci_set_drvdata(pdev, NULL); > + return r; > } > Howabout using out_free_irq, and out_free_ioc, instead of mpterr_freeirq, and mpterr_freeioc, respectively. Thankyou, Eric Moore - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
