[PATCH] aacraid: host_lock not released fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



While doing some testing of error cases I ran into this bug.  In some
cases the reset handler can exit with the host_lock still held.

Signed-off-by: Mark Haverkamp <markh@xxxxxxxx>

---

Index: linux-2.6-aac/drivers/scsi/aacraid/linit.c
===================================================================
--- linux-2.6-aac.orig/drivers/scsi/aacraid/linit.c	2005-10-12 13:24:42.000000000 -0700
+++ linux-2.6-aac/drivers/scsi/aacraid/linit.c	2005-10-13 07:21:24.000000000 -0700
@@ -453,9 +453,9 @@
 		/*
 		 * We can exit If all the commands are complete
 		 */
+		spin_unlock_irq(host->host_lock);
 		if (active == 0)
 			return SUCCESS;
-		spin_unlock_irq(host->host_lock);
 		ssleep(1);
 		spin_lock_irq(host->host_lock);
 	}

-- 
Mark Haverkamp <markh@xxxxxxxx>

-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux