Andrew Vasquez wrote on Wednesday, October 12, 2005 2:10 PM > On Wed, 12 Oct 2005, Chen, Kenneth W wrote: > > Yeah, that would indeed be a very good thing to do. It reminds me > > a while back, I was investigating cache miss profile and we > > consistently see cache misses on tag[2] variable defined in > > qla2x00_start_scsi (used by scsi_populate_tag_msg). Removing it > > would be a very good thing for driver performance. > > > > Should I generate the patch? > > Drop scsi_populate_tag_msg() interrogation. Great! Got a couple "unused variable" compiler warning. You forgot to delete the variable declaration in a hurry ;-) --- ./drivers/scsi/qla2xxx/qla_iocb.c.orig 2005-10-12 14:17:31.544219754 -0700 +++ ./drivers/scsi/qla2xxx/qla_iocb.c 2005-10-12 14:18:08.124297431 -0700 @@ -316,7 +316,6 @@ qla2x00_start_scsi(srb_t *sp) uint16_t req_cnt; uint16_t tot_dsds; struct device_reg_2xxx __iomem *reg; - char tag[2]; /* Setup device pointers. */ ret = 0; @@ -737,7 +736,6 @@ qla24xx_start_scsi(srb_t *sp) uint16_t req_cnt; uint16_t tot_dsds; struct device_reg_24xx __iomem *reg; - char tag[2]; /* Setup device pointers. */ ret = 0; - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
